Deprecate entity slugs #30259
Merged
Deprecate entity slugs #30259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are only used a single time in the whole Nextcloud Github organization. We can inline the code there and slim down the public API. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
requested review from
ArtificialOwl,
R0Wi,
icewind1991,
julien-nc,
mejo-,
miaulalala and
st3iny
miaulalala
approved these changes
Dec 14, 2021
R0Wi
approved these changes
Dec 14, 2021
ChristophWurst
added
4. to release
|
@ChristophWurst just to mention: when the code is removed we should also remove the according section in the docs 👍 |
ChristophWurst
added
the
pending documentation
st3iny
approved these changes
Dec 14, 2021
ChristophWurst
removed
the
pending documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are only used a single time in the whole Nextcloud Github
organization. We can inline the code there and slim down the public API.
https://github.com/nextcloud/bookmarks/blob/c98fe204b0e99e75285918eb996c99393118efce/lib/Service/CrawlService.php#L140 is the one and only usage. @marcelklehr you have three years until this will be removed :)