Reload page instead of file list when getting 401 authentification error#30141
Merged
juliusknorr merged 2 commits intomasterfrom Dec 8, 2021
Merged
Reload page instead of file list when getting 401 authentification error#30141juliusknorr merged 2 commits intomasterfrom
juliusknorr merged 2 commits intomasterfrom
Conversation
When reaching the root dir, instead of reloading the file list we reload the page completely. This trigger a redirection to the login page automatically with the correct ?redirect_url= in thr url. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
requested review from
artonge and
julien-nc
and removed request for
a team
skjnldsv
approved these changes
Dec 7, 2021
Member
Author
|
Hmm actually this only handle the case there we are one folder deep. |
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Member
Author
I changed that to not even checking if we are on the root directory. A 401 should be enough to detect an authentication problem. From my local testing, 401 only happens when there is an authentication problem. 404 is when the folder is missing, 403 is when the user doesn't have access to the folder (e.g. file_accesscontrol) |
CarlSchwan
changed the title
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable22 |
Member
Author
|
/backport to stable21 |
Member
Author
|
We also need to add error handling in apps/viewer/src/services/FileInfo.js... |
julien-nc
approved these changes
Dec 7, 2021
CarlSchwan
changed the title
juliusknorr
approved these changes
Dec 8, 2021
Member
|
Failure unrelated |
This was referenced Dec 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When getting a 401 error, instead of reloading the file list and hopping we are now
authenticated, we reload the page completely. This triggers a redirection to the login
page automatically with the correct ?redirect_url= in the URL, so that once logged the
user goes back to the place they were previously.
Test plan
Signed-off-by: Carl Schwan carl@carlschwan.eu