Do not trigger events when setting active view in gotoplugin #30134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
juliusknorr
approved these changes
Dec 7, 2021
|
/backport to stable23 |
|
/backport to stable22 |
|
/backport to stable21 |
artonge
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using "View in folder" file action (in favorite view for example), the current view is set back to "All files" and the current directory is changed. This produces 2 simultaneous WebDav request to get the file list for (1) the root directory and (2) the actual target directory.
If (1) is the last WebDav request to finish, we end up displaying the root directory content instead of the target dir.
Thankfully there is a simple way to prevent event emission when setting the active view. This way we really make sure the target dir content will be displayed.