Don't write to config file if config_is_read_only is set

[mejo-]

Also don't write to cache in this case to prevent cache and config file
being out of sync.

Fixes: #29901

[mejo-]

I opened a corresponding PR in nextcloud/documentation: nextcloud/documentation#7795

[nickvergessen]

So this means all the paths which set a config need to check for the exception?

[mejo-]

So this means all the paths which set a config need to check for the exception?

Right now, a config file with read-only permissions throws the same kind of exception. So in my eyes, adding the check is not a regression to how it was before. What do you think?

I agree that proper notifications about the config file being set to read-only would be nice in the long term. But that can be tackled in another PR later, no?

[solracsf]

Does it make sense to use OC::$CLI so writes would always be possible using the CLI?

if (OC::$CLI) {
  // write
} else {
  // exception
}

[nickvergessen]

That also is true for cron jobs where I would not expects write to happen.

[mejo-]

So this means all the paths which set a config need to check for the exception?

Do you mean that throwing the exception should be exposed on the interface (IConfig) as well, similar to @ChristophWurst's comment? If so, then I added this now: https://github.com/nextcloud/server/pull/30130/files#diff-54875ef8945bf07212017eccde83d6400812202ce1e30227e9fda9e92fa9474d

[juliusknorr]

Leaving the merge to a re-review from @ChristophWurst or @nickvergessen

[ChristophWurst]

[ChristophWurst]

@mejo- please add this to #29914 and update the developer docs about the change ✌️

[mejo-]

Yay, thanks @ChristophWurst!

Added to #29914. Docs should be updated automatically with this PR. At least @nickvergessen said that admin_manual/configuration_server/config_sample_php_parameters.rst will be auto-generated from config/config.sample.php in nextcloud/documentation#7795. Or what do you mean with "developer docs"?

[ChristophWurst]

The admin docs will be updated with the sample config, yes. But https://docs.nextcloud.com/server/latest/developer_manual/basics/storage/configuration.html should receive an update about the new exception

[mejo-]

The admin docs will be updated with the sample config, yes. But https://docs.nextcloud.com/server/latest/developer_manual/basics/storage/configuration.html should receive an update about the new exception

Ah, thanks for the pointer! Did this now: nextcloud/documentation#7851