-
-
Couldn't load subscription status.
- Fork 4.6k
Bump scssphp/scssphp to 1.8.1 #30034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Can someone familiar enough look into https://scssphp.github.io/scssphp/docs/changelog.html and see how big the impact of this bump is? We had 1.4.0 before so it’s a pretty big bump, I’m not sure if the psalm spotted problem is the only one. |
This ports away from using now internal functions from scssphp. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
|
I just did some small grepping and the only misused was the one reported by psaml and I fixed it. Other than that locally everything seems to still works and I followed https://scssphp.github.io/scssphp/docs/#security-considerations to do a bit of hardening |
f9f53e6 to
b706bba
Compare
See https://scssphp.github.io/scssphp/docs/#security-considerations Signed-off-by: Carl Schwan <carl@carlschwan.eu>
30098c8 to
dfb569f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can merge but note that this scsscacher should go away as soon as we have the time to :)
|
@skjnldsv You merged here but it was needed to merge nextcloud/3rdparty#934 first and then rebase here to use the merge commit. |
|
@come-nc make your PR a draft next time 😉 |
But can it get approvals while still being a draft? I wait for CI and approvals on server side before merging 3rdparty side, I thought this was not possible with a draft. |
|
(3rdparty was merged, fixing PR server-side incoming) |
yes |
Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com
nextcloud/3rdparty#934