Cast orphan subscription id to int#30001
Merged
ChristophWurst merged 1 commit intomasterfrom Dec 1, 2021
Merged
Conversation
DB columns are of type int by default, so they need to be casted. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
added
bug
3. to review
ChristophWurst
requested review from
a team,
miaulalala,
st3iny and
tcitworld
ChristophWurst
requested review from
CarlSchwan,
nickvergessen and
skjnldsv
and removed request for
a team
Member
Author
|
/backport to stable23 |
Member
Author
|
@tcitworld was this not backported? #28716 (comment) |
Member
Apparently not 🤷 |
miaulalala
approved these changes
Dec 1, 2021
Member
Author
The bot doesn't want to backport your PR apparently 😢 |
skjnldsv
approved these changes
Dec 1, 2021
|
I just downloaded it with updater.phar and tried to execute occ upgrade... when are you going to release the fixed version? |
Member
Author
|
ok they changed it. i'll wait thenks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://help.nextcloud.com/t/nextcloud-23-upgrade-problem-dav-app/128275/7
DB columns are of type int by default, so they need to be casted. Otherwise the invocation of
\OCA\DAV\Migration\RemoveDeletedUsersCalendarSubscriptions::deleteOrphanSubscriptioncauses a type error.Ref #28716