Support seeking also from the end of file on S3 storage #28802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR nextcloud#20033 added support for `fseek` for the S3 storage backend. However, the seek mode SEEK_END was left out that time. This PR fills this gap. Signed-off-by: Pauli Järvinen <pauli.jarvinen@gmail.com>
szaimen
requested review from
a team,
PVince81 and
blizzz
and removed request for
a team
juliusknorr
approved these changes
Sep 14, 2021
|
Failure unrelated |
|
does it make sense to backport? |
In my opinion, yes. This fixes an actual problem, and the patch should be applicable all the way starting from NC17. |
|
So who should decide if this gets backported? |
|
/backport to stable22 |
|
/backport to stable21 |
|
/backport to stable20 |
This was referenced Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #20033 added support for
fseekfor the S3 storage backend. However, the seek mode SEEK_END was left out that time. This PR adds this support.The motivation for this was that the getID3 library uses the seek mode SEEK_END and doesn't work properly without it. After the PR JamesHeinrich/getID3#328 got merged, the getID3 library no longer works at all on file system where
fseekreturns error with any used seek mode. This was the root cause for the issue owncloud/music#887.