Skip to content

Conversation

@juliusknorr
Copy link
Member

Otherwise PHP errors with any level would cause an ErrorException that would make the code behave as if the operation failed.

E.g. as reported in #28463 where the sesison gc failed which then leads to the session cookie being invalidated in

try {
$this->startSession();
} catch (\Exception $e) {
setcookie($this->invoke('session_name'), '', -1, \OC::$WEBROOT ?: '/');
}
See #28463 (comment) for more details.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels Aug 17, 2021
@juliusknorr juliusknorr added this to the Nextcloud 23 milestone Aug 17, 2021
@skjnldsv skjnldsv merged commit 0edfb24 into master Aug 17, 2021
@skjnldsv skjnldsv deleted the bugfix/noid/session-error-handling branch August 17, 2021 09:39
@juliusknorr
Copy link
Member Author

/backport to stable22

@juliusknorr
Copy link
Member Author

/backport to stable21

@juliusknorr
Copy link
Member Author

/backport to stable20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants