-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Make "name" column nullable for workflows #28318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
note, I've seen in the JS code that this column is actually legacy and not used any more, see https://github.com/nextcloud/server/blob/master/apps/workflowengine/src/store.js#L105 so probably in the next major version we could remove it completely. but here I needed a small less impactful fix that we can backport |
238825d to
9beea1b
Compare
9beea1b to
5a7c7c4
Compare
okay.... |
|
weird, so I'll git add it but let me know if this is wrong... |
5a7c7c4 to
9799ea1
Compare
|
failing test is unrelated, the previous run had a different integration test failing @juliushaertl can you recheck ? |
|
another weird thing is that apps/workflowengine has a composer folder but no composer.json file, so the dump-autoloader function fails with "No lockfile found. Unable to read locked packages". so how are we supposed to update the autoloader files in apps with or maybe it's the newer composer that refuses that. |
|
I've asked Arthur to run the script locally and he mentioned no issues when updating, with the same composer version and PHP 7.4.15 so maybe there's something strange in my environment, I'll debug this locally |
The "name" column is now unused and the code is always inserting an empty string. While this works with most databases, Oracle complains because an empty string is equivalent to null. To fix this, the column definition is changed to allow null values now. Also added some logging in case of database exceptions, because without this nothing would be logged to detect the above problem. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
9799ea1 to
15a62c5
Compare
|
I've managed to clean the autoloader mess by running the script on a different environment. Please recheck |
|
/backport to stable22 |
|
/backport to stable21 |
|
/backport to stable20 |
The "name" column is now unused and the code is always inserting an
empty string. While this works with most databases, Oracle complains
because an empty string is equivalent to null.
To fix this, the column definition is changed to allow null values now.
Also added some logging in case of database exceptions, because without
this nothing would be logged to detect the above problem.