Fix Files breadcrumbs being hidden even if there is enough space#27920
Merged
Fix Files breadcrumbs being hidden even if there is enough space#27920
Conversation
julien-nc
requested review from
jancborchardt,
jospoortvliet,
marcoambrosini,
raimund-schluessler and
stefan-niedermann
marcoambrosini
approved these changes
Jul 12, 2021
Member
Author
|
/backport to stable22 |
Member
Author
|
/backport to stable21 |
Member
Author
|
/backport to stable20 |
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
julien-nc
force-pushed
the
fix/21263/breadcrumb-wrong-float-width-comparison
branch
from
d8a3fd4 to
c4fcf4c
Compare
Member
Author
|
Drone CI failure is unrelated (sharing stuff). |
This was referenced Jul 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #21263
In Files breadcrumb management, we sometimes get floats in width calculations. This can lead to wrong comparison results when sizes are almost the same.
At some point this will be fixed by using the Breadcrumb Vue component. Until then, here is a solution.
Make sure you set
debugtotrueinconfig/config.phpto try these changes.