Reset checksum when writing files to object store #27586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
are backports necessary? |
kesselb
reviewed
Jun 22, 2021
icewind1991
approved these changes
Jun 24, 2021
juliusknorr
added
4. to release
|
/backport to stable22 |
|
/backport to stable21 |
|
/backport to stable20 |
Hello, do you think it would be possible to backport it to 19? Or is it risky/not recommended? Thanks for your help :) |
19 is having its last release today and goes EOL. So it would not get included. |
This was referenced Jul 1, 2021
Oh, didn't know that. Thanks for the info ! Gotta update quick I guess :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a local storage the checksum will be reset when scanning the file after writing to it:
server/lib/private/Files/Cache/Scanner.php
Line 222 in 215aef3
This does not work for object store storage backends as those use a NoopScanner so the checksum was never reset for those.
Fixes #27563