[stable20] Activate constraint check for oracle / pqsql also for 20#27523
Merged
[stable20] Activate constraint check for oracle / pqsql also for 20#27523
Conversation
kesselb
changed the title
kesselb
requested review from
ChristophWurst,
blizzz,
nickvergessen and
skjnldsv
kesselb
added
3. to review
skjnldsv
approved these changes
Jun 16, 2021
nickvergessen
approved these changes
Jun 16, 2021
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
bug/noid/unreachable-check-query-builder
branch
from
d2be11d to
3b510bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like something went wrong during the backport. For Nextcloud 20 the query is executed before the check for the oracle / pqsql constraints.
I guess there are still some places not using chunked queries. Unsure if enabling the constraint checks for Nextcloud 20 with the next patch release is a good idea.