Extend Accounts with multivalue properties (PropertyCollection) #27189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
changed the title
blizzz
added
3. to review
blizzz
force-pushed
the
feat/26866/account-collection-properties
branch
from
510f6ba to
44827e3
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
- in fact the API could be done in a nicer way and it might be possible to work without IAccountPropertyCollection, but only with the IAccountProperties. - To keep it simple at first and not overengineer the blunt attempt is followed - If necessary helpful in the further cause of development adjustements or extensions can be done quickly with this base Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
added
2. developing
|
need to convince psalm tomorrow |
|
@blizzz I'll be working on frontend integration so any more helper functions would be great 🙌, on the backend I'll leave the nitty-gritty logic for you to work on though I'll probably be working on the UsersController as we're using the provisioning_api :) |
Pytal
force-pushed
the
feat/26866/account-collection-properties
branch
from
e4e8e36 to
8235d90
Compare
blizzz
force-pushed
the
feat/26866/account-collection-properties
branch
from
8235d90 to
35d5395
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de> psalm happiness Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
added
3. to review
Pytal
approved these changes
Jun 7, 2021
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
IAccountManagermultivalue properties are declared as constants prefixedCOLLECTION. One such constant was added:COLLECTION_EMAILThe
IAccountPropertyCollectionis introduced which is a container forIAccountProperties.IAccountwas extended with three methods. Two that are there for setting and getting property collections. The thought behind this is to keep the API stable and is oriented on the existing methods for consistency. Another,getAllProperties()was introduced in order to deprecategetPropertieswhich is left untouched for backports compatibility. Both methods returnIAccountProperty[], but the old method uses the property name as index, which is not possible with multiple values. The new method flattens the Collections and returns each value as its ownIAccountPropertyfor simplicity.Contrary
getFilteredPropertieswas adjusted to return all values matching the criteria also from collections (also flattened). The resulting array structure was not documented before and was therefore adjusted (associative, index names of collections are appended by #0, #1…). This is backwards compatible.And of course the concrete implementations are adjusted.
contributes to #26866
(fwiw, this is @blizzz writing and owning it, not @skjnldsv)