fix error when using CORS with no auth credentials#26852
Merged
nickvergessen merged 1 commit intomasterfrom May 19, 2021
Merged
fix error when using CORS with no auth credentials#26852nickvergessen merged 1 commit intomasterfrom
nickvergessen merged 1 commit intomasterfrom
Conversation
nickvergessen
approved these changes
May 1, 2021
nickvergessen
approved these changes
May 3, 2021
Member
Author
|
ping for review @rullzer @ChristophWurst @LukasReschke @kesselb |
1533634 to
b38e867
Compare
LukasReschke
approved these changes
May 18, 2021
Member
Author
|
I suggest to Backport this to stable20 and stable21. Can we do this? |
Member
|
/backport to stable21 |
Member
|
/backport to stable20 |
This was referenced May 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using an
ApiControllerwithCORSannotation, basic authentication is required. However, currently the following exception occurs when a request does not contain any authentication:In consultation with @nickvergessen , this PR fixes this by checking if
$userand$passare not null before trying to login.Furthermore, I fixed an
Undefined index errorforPHP_AUTH_USERandPHP_AUTH_PW.I suggest backporting this to the stable branches.