Cleanup files sidebar navigation manager #26320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
icewind1991
commented
Mar 26, 2021
•
icewind1991
commented
- Move it to it's own class so it can be queried
- Deprecate old method for getting it
- Remove deprecated usages within this repo
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
changed the title
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
files-sidebar-navmanager
branch
from
4e35864
to
f6be7a4
Compare
icewind1991
added
3. to review
MorrisJobke
reviewed
Mar 29, 2021
| @@ -31,6 +31,7 @@ | |||
| namespace OCA\Files_Sharing\AppInfo; | |||
|
|
|||
| use OC\AppFramework\Utility\SimpleContainer; | |||
| use OCA\Files\SidebarNavigationManager; | |||
There was a problem hiding this comment.
@ChristophWurst @rullzer We should move this to the OCP namespace, or? A way to hook into the files app sidebar. Or should we say "it's fine, because files app is force enabled anyways"?
There was a problem hiding this comment.
It should be OCP ideally because otherwise we can never set any clear boundaries between public and private API
blizzz
added
2. developing
|
moving to 23 |
Merged
Merged
Merged
Merged
Merged
Merged
Merged
|
closing for inactivity and amount of conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.