Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable19] Avoid creating two share links when password is enforced #25741

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Feb 22, 2021

backport of #25602

@faily-bot
Copy link

faily-bot bot commented Feb 22, 2021

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 2466: failure

mysql5.6-php7.2

Show full log
There was 1 error:

1) OCA\FederatedFileSharing\Tests\FederatedShareProviderTest::testGetSharedByWithReshares
OCP\Share\Exceptions\ShareNotFound: There was an error retrieving the share. Maybe the link is wrong, it was unshared, or it was deleted.

/drone/src/apps/federatedfilesharing/lib/FederatedShareProvider.php:863
/drone/src/apps/federatedfilesharing/lib/FederatedShareProvider.php:242
/drone/src/apps/federatedfilesharing/tests/FederatedShareProviderTest.php:658

--

There were 5 warnings:

1) Test\DB\QueryBuilder\QueryBuilderTest::testExecuteWithParameterTooLarge
Cannot stub or mock class or interface "Doctrine\DBAL\Result" which does not exist

2) Test\DB\QueryBuilder\QueryBuilderTest::testExecuteWithParametersTooMany
Cannot stub or mock class or interface "Doctrine\DBAL\Result" which does not exist

3) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

4) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

5) OCA\Files_Sharing\Tests\External\ManagerTest::testAddShare
Cannot stub or mock class or interface "OCA\Files_Sharing\Tests\External\IManager" which does not exist

@skjnldsv
Copy link
Member

/compile amend /

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
@rullzer rullzer added the 3. to review Waiting for reviews label Mar 1, 2021
@rullzer rullzer merged commit a00eff8 into stable19 Mar 1, 2021
@rullzer rullzer deleted the backport/25602/stable19 branch March 1, 2021 11:49
@rullzer rullzer mentioned this pull request Mar 26, 2021
@rullzer rullzer mentioned this pull request Apr 8, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants