Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply object store copy optimization when 'cross storage' copy is wit… #25722

Merged
merged 1 commit into from
Mar 12, 2021
Merged

apply object store copy optimization when 'cross storage' copy is wit… #25722

merged 1 commit into from
Mar 12, 2021

Conversation

icewind1991
Copy link
Member

…hin the same object store

This applies to copying from/to groupfolders, shares, etc.

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Feb 19, 2021
@icewind1991 icewind1991 added this to the Nextcloud 22 milestone Feb 19, 2021
@faily-bot
Copy link

faily-bot bot commented Feb 19, 2021

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 2441: failure

acceptance-users

  • tests/acceptance/features/users.feature:47
Show full log 
  Scenario: users navigation without disabled users                                   # /drone/src/tests/acceptance/features/users.feature:47
    Given I act as Jane                                                               # ActorContext::iActAs()
    And I am logged in as the admin                                                   # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                                      # SettingsMenuContext::iOpenTheUserSettings()
    And I open the "Disabled users" section                                           # AppNavigationContext::iOpenTheSection()
    And I see that the list of users contains the user disabledUser                   # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    And I open the actions menu for the user disabledUser                             # UsersSettingsContext::iOpenTheActionsMenuOf()
      Row for user disabledUser in Users Settings could not be found
      Actions menu for user disabledUser in Users Settings could not be found (NoSuchElementException)
    And I see that the "Enable user" action in the disabledUser actions menu is shown # UsersSettingsContext::iSeeTheAction()
    When I click the "Enable user" action in the disabledUser actions menu            # UsersSettingsContext::iClickTheAction()
    Then I see that the section "Disabled users" is not shown                         # AppNavigationContext::iSeeThatTheSectionIsNotShown()
    When I open the User settings                                                     # SettingsMenuContext::iOpenTheUserSettings()
    Then I see that the section "Disabled users" is not shown                         # AppNavigationContext::iSeeThatTheSectionIsNotShown()

PVince81
PVince81 approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@rullzer
Copy link
Member

rullzer commented Mar 4, 2021

psalm is not happy and neither is the php-cs checker ;)

@icewind1991
Copy link
Member Author

made cs and psalm happy and squashed

@icewind1991 @rullzer
apply object store copy optimization when 'cross storage' copy is wit…
c87b1a5 
…hin the same object store

Signed-off-by: Robin Appelman <robin@icewind.nl>
@PVince81
Copy link
Member

restarted failed build

@icewind1991 icewind1991 merged commit 32551b9 into master Mar 12, 2021
@icewind1991 icewind1991 deleted the objectstore-copy-cross branch March 12, 2021 16:10
@icewind1991
Copy link
Member Author

/backport to stable21

@icewind1991
Copy link
Member Author

/backport to stable20

@icewind1991
Copy link
Member Author

/backport to stable19

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 12, 2021
Merged
This was referenced Mar 12, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@PVince81 PVince81 PVince81 approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.
3 participants
@icewind1991 @rullzer @PVince81