Skip to content

Make new result parts optional #25612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2021
Merged

Make new result parts optional #25612

merged 1 commit into from
Feb 13, 2021

Conversation

@nickvergessen
Copy link
Member

Found in company log:

"message":{"Exception":"Error","Message":"Undefined index: icon at /var/www/html/core/Controller/AutoCompleteController.php#118"
"message":{"Exception":"Error","Message":"Undefined index: status at /var/www/html/core/Controller/AutoCompleteController.php#120"
"message":{"Exception":"Error","Message":"Undefined index: subline at /var/www/html/core/Controller/AutoCompleteController.php#121"

Regression from e7f5516

@nickvergessen
Make new result parts optional
83755b7 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Feb 12, 2021
@nickvergessen nickvergessen added this to the Nextcloud 22 milestone Feb 12, 2021
rullzer
rullzer approved these changes Feb 12, 2021
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

ChristophWurst
ChristophWurst approved these changes Feb 12, 2021
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maxence

@rullzer rullzer merged commit 5b43afd into master Feb 13, 2021
@rullzer rullzer deleted the bugfix/noid/make-new-result-parts-optional branch February 13, 2021 13:55
@nickvergessen
Copy link
Member Author

/backport to stable21

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @rullzer @ChristophWurst