Bump phpseclib/phpseclib from 2.0.25 to 2.0.30#25214
Merged
MorrisJobke merged 3 commits intomasterfrom Jan 21, 2021
Merged
Conversation
e82e6fa to
15aab23
Compare
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
15aab23 to
4373afe
Compare
Member
|
Ok got it. So the new phpseclib fails on parsing the root.crt since it contains more than 1 cert. We still ahve to fix:
|
So we have to split it manually and do it ourselves Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
| * @return string[] | ||
| */ | ||
| private function splitCerts(string $cert): array { | ||
| preg_match_all('([\-]{3,}[\S\ ]+?[\-]{3,}[\S\s]+?[\-]{3,}[\S\ ]+?[\-]{3,})', $cert, $matches); |
Member
There was a problem hiding this comment.
Luckily we have tests that confirm this 🙈
Member
Author
|
I think drone got stuck |
Member
|
yeah restarted it so lets see |
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 1555: failureacceptance-app-files-sharing-link
Show full log |
Member
|
So now different tests |
rullzer
approved these changes
Jan 21, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nextcloud/3rdparty#592