Set the JSCombiner cache if needed #24988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found while debugging a customer setup. They had to flush their Redis. Hence the info was no longer there. Since they also used S3 this meant requesting the files over and over on template render. Which on S3 is not cheap. Now we just write it back if we can't get it from the cache in the first place. So that the next run has it cached properly again. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
requested review from
MorrisJobke,
ChristophWurst,
juliusknorr and
skjnldsv
|
/backport to stable20 |
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 1019: failuremariadb10.4-php7.4Show full log |
ChristophWurst
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while debugging a customer setup. They had to flush their Redis.
Hence the info was no longer there. Since they also used S3 this meant
requesting the files over and over on template render. Which on S3 is
not cheap.
Now we just write it back if we can't get it from the cache in the first
place. So that the next run has it cached properly again.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl