Skip to content

Don't throw a 500 when importing a broken ics reminder file #24964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2021
Merged

Don't throw a 500 when importing a broken ics reminder file #24964

merged 1 commit into from
Jan 5, 2021

Conversation

@nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling coding@schilljs.com

@nickvergessen
Don't throw a 500 when importing a broken ics reminder file
9fd2b60 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 21 milestone Jan 5, 2021
@nickvergessen
Copy link
Member Author

/backport to stable20

@nickvergessen
Copy link
Member Author

/backport to stable19

@nickvergessen
Copy link
Member Author

/backport to stable18

@faily-bot
Copy link

faily-bot bot commented Jan 5, 2021

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 960: failure

mariadb10.4-php7.4

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Config\UserMountCacheTest::testNewMounts
Failed asserting that actual size 0 matches expected size 1.

/drone/src/tests/lib/Files/Config/UserMountCacheTest.php:118

@rullzer rullzer merged commit 50b380e into master Jan 5, 2021
@rullzer rullzer deleted the bugfix/noid/internal-server-error-when-importing-broken-ics-file branch January 5, 2021 11:57
This was referenced Jan 5, 2021
Merged
Merged
Merged
@rullzer rullzer mentioned this pull request Jan 6, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@georgehrke georgehrke Awaiting requested review from georgehrke

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: dav

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @rullzer @ChristophWurst