Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable19] Store scss variables under a different prefix for each theming config version #24452

Merged
merged 1 commit into from
Nov 30, 2020
Merged

[stable19] Store scss variables under a different prefix for each theming config version #24452

merged 1 commit into from
Nov 30, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #24449

@juliushaertl @backportbot
Store scss variables under a different prefix for each theming config…
7378795 
… version

The main issue with using the general theming- prefix is that with APCu caching
the cache is not shared between processes, so when trying to reset the cache
through the CLI, e.g. when updating the theming config the old cache is never
invalidated.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 19.0.6 milestone Nov 30, 2020
@faily-bot
Copy link

faily-bot bot commented Nov 30, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 36097: failure

mariadb10.4-php7.3

Show full log 
There were 3 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

3) OCA\Files_Sharing\Tests\External\ManagerTest::testAddShare
Cannot stub or mock class or interface "OCA\Files_Sharing\Tests\External\IManager" which does not exist

--

There was 1 failure:

1) Test\Files\Cache\Wrapper\CacheJailTest::testSimple
Failed asserting that 0 matches expected 689.

/drone/src/tests/lib/Files/Cache/CacheTest.php:81

@MorrisJobke MorrisJobke merged commit 4d34133 into stable19 Nov 30, 2020
@MorrisJobke MorrisJobke deleted the backport/24449/stable19 branch November 30, 2020 15:54
This was referenced Dec 1, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@rullzer rullzer Awaiting requested review from rullzer

Assignees
No one assigned
Labels
bug feature: theming
Projects
None yet
Milestone
Nextcloud 19.0.6
Development

Successfully merging this pull request may close these issues.
3 participants
@MorrisJobke @skjnldsv @juliushaertl