[stable20] Fix public calendars shared to circles #24446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
as the QueryException is already catched inside circleToPrincipal. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
The circles app depends on a valid userId. A public shared calender might be viewed by guests without a user session. For such requests the principal is null. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
backportbot-nextcloud
bot
requested review from
ChristophWurst,
ArtificialOwl,
juliushaertl,
kesselb,
MorrisJobke,
rullzer,
skjnldsv and
tcitworld
MorrisJobke
approved these changes
Nov 30, 2020
skjnldsv
approved these changes
Nov 30, 2020
MorrisJobke
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #23652