Also lint php8

[rullzer]

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 35759: failure

mysql5.6-php7.3

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Share20\DefaultShareProviderTest::testDeleteUser with data set #1 (0, 'a', 'b', 'c', 'b', false)
Failed asserting that actual size 0 matches expected size 1.

/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:2255

acceptance-app-files-sharing

• tests/acceptance/features/app-files-sharing.feature:138
• tests/acceptance/features/app-files-sharing.feature:249
• tests/acceptance/features/app-files-sharing.feature:266
• tests/acceptance/features/app-files-sharing.feature:291
• tests/acceptance/features/app-files-sharing.feature:353
• tests/acceptance/features/app-files-sharing.feature:376

Show full log

  Scenario: share an empty folder with another user                           # /drone/src/tests/acceptance/features/app-files-sharing.feature:138
    Given I act as John                                                       # ActorContext::iActAs()
    And I am logged in as the admin                                           # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I act as Jane                                                         # ActorContext::iActAs()
    And I am logged in                                                        # LoginPageContext::iAmLoggedIn()
    And I act as John                                                         # ActorContext::iActAs()
    And I create a new folder named "Shared folder"                           # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Shared folder"        # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    When I share "Shared folder" with "user0"                                 # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                            # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as Jane                                                         # ActorContext::iActAs()
    And I open the Files app                                                  # FilesAppContext::iOpenTheFilesApp()
    Then I see that the file list contains a file named "Shared folder"       # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I open the details view for "Shared folder"                           # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                   # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I open the "Sharing" tab in the details view                          # FilesAppContext::iOpenTheTabInTheDetailsView()
      Tab headers in details view in Files app could not be found after 100 seconds
      Tab header named Sharing in details view in Files app could not be found after 100 seconds (NoSuchElementException)
    And I see that the "Sharing" tab in the details view is eventually loaded # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
    And I see that the file is shared with me by "admin"                      # FilesAppSharingContext::iSeeThatTheFileIsSharedWithMeBy()

  Scenario: sharer does not see resharing option for a folder if resharing is disabled in the settings after the share is created # /drone/src/tests/acceptance/features/app-files-sharing.feature:249
    Given I am logged in as the admin                                                                                             # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I create a new folder named "Shared folder"                                                                               # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Shared folder"                                                            # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I share "Shared folder" with "user0"                                                                                      # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                                                                                # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    When I visit the settings page                                                                                                # SettingsMenuContext::iVisitTheSettingsPage()
    And I open the "Sharing" section of the "Administration" group                                                                # AppNavigationContext::iOpenTheSectionOf()
    And I disable resharing                                                                                                       # SettingsContext::iDisableResharing()
    And I see that resharing is disabled                                                                                          # SettingsContext::iSeeThatResharingIsDisabled()
    Then I open the Files app                                                                                                     # FilesAppContext::iOpenTheFilesApp()
    And I open the details view for "Shared folder"                                                                               # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                                                                       # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I open the "Sharing" tab in the details view                                                                              # FilesAppContext::iOpenTheTabInTheDetailsView()
      Tab headers in details view in Files app could not be found after 100 seconds
      Tab header named Sharing in details view in Files app could not be found after 100 seconds (NoSuchElementException)
    And I see that the "Sharing" tab in the details view is eventually loaded                                                     # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
    And I see that resharing for "user0" is not available                                                                         # FilesAppSharingContext::iSeeThatResharingForIsNotAvailable()

  Scenario: sharee can not reshare a folder if resharing is disabled in the settings after the share is created # /drone/src/tests/acceptance/features/app-files-sharing.feature:266
    Given I act as John                                                                                         # ActorContext::iActAs()
    And I am logged in as the admin                                                                             # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I act as Jane                                                                                           # ActorContext::iActAs()
    And I am logged in                                                                                          # LoginPageContext::iAmLoggedIn()
    And I act as John                                                                                           # ActorContext::iActAs()
    And I create a new folder named "Shared folder"                                                             # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Shared folder"                                          # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I share "Shared folder" with "user0"                                                                    # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                                                              # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I visit the settings page                                                                               # SettingsMenuContext::iVisitTheSettingsPage()
    And I open the "Sharing" section of the "Administration" group                                              # AppNavigationContext::iOpenTheSectionOf()
    And I disable resharing                                                                                     # SettingsContext::iDisableResharing()
    And I see that resharing is disabled                                                                        # SettingsContext::iSeeThatResharingIsDisabled()
    When I act as Jane                                                                                          # ActorContext::iActAs()
    And I open the Files app                                                                                    # FilesAppContext::iOpenTheFilesApp()
    Then I see that the file list contains a file named "Shared folder"                                         # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I open the details view for "Shared folder"                                                             # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                                                     # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I open the "Sharing" tab in the details view                                                            # FilesAppContext::iOpenTheTabInTheDetailsView()
      Tab headers in details view in Files app could not be found after 100 seconds
      Tab header named Sharing in details view in Files app could not be found after 100 seconds (NoSuchElementException)
    And I see that the "Sharing" tab in the details view is eventually loaded                                   # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
    And I see that the file is shared with me by "admin"                                                        # FilesAppSharingContext::iSeeThatTheFileIsSharedWithMeBy()
    And I see that resharing the file is not allowed                                                            # FilesAppSharingContext::iSeeThatResharingTheFileIsNotAllowed()

  Scenario: sharee can unshare a folder if resharing is disabled in the settings after the share is created # /drone/src/tests/acceptance/features/app-files-sharing.feature:291
    Given I act as John                                                                                     # ActorContext::iActAs()
    And I am logged in as the admin                                                                         # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I act as Jane                                                                                       # ActorContext::iActAs()
    And I am logged in                                                                                      # LoginPageContext::iAmLoggedIn()
    And I act as John                                                                                       # ActorContext::iActAs()
    And I create a new folder named "Shared folder"                                                         # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Shared folder"                                      # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I share "Shared folder" with "user0"                                                                # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                                                          # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as Jane                                                                                       # ActorContext::iActAs()
    And I open the Files app                                                                                # FilesAppContext::iOpenTheFilesApp()
    And I share "Shared folder" with "user1"                                                                # FilesAppSharingContext::iShareWith()
    And I act as John                                                                                       # ActorContext::iActAs()
    And I visit the settings page                                                                           # SettingsMenuContext::iVisitTheSettingsPage()
    And I open the "Sharing" section of the "Administration" group                                          # AppNavigationContext::iOpenTheSectionOf()
    And I disable resharing                                                                                 # SettingsContext::iDisableResharing()
    And I see that resharing is disabled                                                                    # SettingsContext::iSeeThatResharingIsDisabled()
    When I act as Jane                                                                                      # ActorContext::iActAs()
    And I open the Files app                                                                                # FilesAppContext::iOpenTheFilesApp()
    Then I see that the file list contains a file named "Shared folder"                                     # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I open the details view for "Shared folder"                                                         # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                                                 # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I open the "Sharing" tab in the details view                                                        # FilesAppContext::iOpenTheTabInTheDetailsView()
      Tab headers in details view in Files app could not be found after 100 seconds
      Tab header named Sharing in details view in Files app could not be found after 100 seconds (NoSuchElementException)
    And I see that the "Sharing" tab in the details view is eventually loaded                               # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
    And I see that the file is shared with me by "admin"                                                    # FilesAppSharingContext::iSeeThatTheFileIsSharedWithMeBy()
    And I unshare the share with "user1"                                                                    # FilesAppSharingContext::iUnshareTheFileWith()
    And I see that the file is not shared with "user1"                                                      # FilesAppSharingContext::iSeeThatTheFileIsNotSharedWith()

  Scenario: sharee can not reshare a folder if the sharer disables it         # /drone/src/tests/acceptance/features/app-files-sharing.feature:353
    Given I act as John                                                       # ActorContext::iActAs()
    And I am logged in as the admin                                           # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I act as Jane                                                         # ActorContext::iActAs()
    And I am logged in                                                        # LoginPageContext::iAmLoggedIn()
    And I act as John                                                         # ActorContext::iActAs()
    And I create a new folder named "Shared folder"                           # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Shared folder"        # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I share "Shared folder" with "user0"                                  # FilesAppSharingContext::iShareWith()
      │ Share with input in the details view in Files app value could not be set
      │ Exception message: Element is not currently visible and so may not be interacted with
      │ Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
      │ System info: host: '9681b47d2b03', ip: '192.168.208.2', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-88-generic', java.version: '1.8.0_91'
      │ Driver info: driver.version: unknown
      │ Trying again
      │ 
    And I see that the file is shared with "user0"                            # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I set the share with "user0" as not reshareable                       # FilesAppSharingContext::iSetTheShareWithAsNotReshareable()
    And I see that "user0" can not reshare the share                          # FilesAppSharingContext::iSeeThatCanNotReshareTheShare()
    When I act as Jane                                                        # ActorContext::iActAs()
    And I open the Files app                                                  # FilesAppContext::iOpenTheFilesApp()
    Then I see that the file list contains a file named "Shared folder"       # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I open the details view for "Shared folder"                           # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                   # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I open the "Sharing" tab in the details view                          # FilesAppContext::iOpenTheTabInTheDetailsView()
      Tab headers in details view in Files app could not be found after 100 seconds
      Tab header named Sharing in details view in Files app could not be found after 100 seconds (NoSuchElementException)
    And I see that the "Sharing" tab in the details view is eventually loaded # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
    And I see that the file is shared with me by "admin"                      # FilesAppSharingContext::iSeeThatTheFileIsSharedWithMeBy()
    And I see that resharing the file is not allowed                          # FilesAppSharingContext::iSeeThatResharingTheFileIsNotAllowed()

  Scenario: sharee can not reshare a subfolder if the sharer disables it for the parent folder # /drone/src/tests/acceptance/features/app-files-sharing.feature:376
    Given I act as John                                                                        # ActorContext::iActAs()
    And I am logged in as the admin                                                            # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I act as Jane                                                                          # ActorContext::iActAs()
    And I am logged in                                                                         # LoginPageContext::iAmLoggedIn()
    And I act as John                                                                          # ActorContext::iActAs()
    And I create a new folder named "Shared folder"                                            # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Shared folder"                         # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I share "Shared folder" with "user0"                                                   # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                                             # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I set the share with "user0" as not reshareable                                        # FilesAppSharingContext::iSetTheShareWithAsNotReshareable()
    And I see that "user0" can not reshare the share                                           # FilesAppSharingContext::iSeeThatCanNotReshareTheShare()
    And I enter in the folder named "Shared folder"                                            # FileListContext::iEnterInTheFolderNamed()
    And I create a new folder named "Subfolder"                                                # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Subfolder"                             # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    When I act as Jane                                                                         # ActorContext::iActAs()
    And I open the Files app                                                                   # FilesAppContext::iOpenTheFilesApp()
    And I enter in the folder named "Shared folder"                                            # FileListContext::iEnterInTheFolderNamed()
    Then I see that the file list contains a file named "Subfolder"                            # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I open the details view for "Subfolder"                                                # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                                    # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I open the "Sharing" tab in the details view                                           # FilesAppContext::iOpenTheTabInTheDetailsView()
      Tab headers in details view in Files app could not be found after 100 seconds
      Tab header named Sharing in details view in Files app could not be found after 100 seconds (NoSuchElementException)
    And I see that the "Sharing" tab in the details view is eventually loaded                  # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
    And I see that resharing the file is not allowed                                           # FilesAppSharingContext::iSeeThatResharingTheFileIsNotAllowed()