Skip to content

[stable19] Do not emit UserCreatedEvent twice #23931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2020
Merged

[stable19] Do not emit UserCreatedEvent twice #23931

merged 2 commits into from
Nov 6, 2020

Conversation

@backportbot-nextcloud
Copy link

backport of #23917

Tobias Assmann added 2 commits November 6, 2020 09:58
@backportbot
fix: no more translation from postCreateUser hook to UserCreatedEvent…
ed46c5c 
… anymore, as event is already emitted in user manager

Signed-off-by: Tobias Assmann <tobias.assmann@ecsec.de>
@backportbot
fix: also remove use statement of UserCreatedEvent
dff1023 
Signed-off-by: Tobias Assmann <tobias.assmann@ecsec.de>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 19.0.5 milestone Nov 6, 2020
@rullzer rullzer added the 3. to review Waiting for reviews label Nov 6, 2020
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 6, 2020
@ChristophWurst ChristophWurst changed the title [stable19] [stable20] Do not emit UserCreatedEvent twice [stable19] Do not emit UserCreatedEvent twice Nov 6, 2020
@faily-bot
Copy link

faily-bot bot commented Nov 6, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 35112: failure

mysql8.0-php7.2

Show full log 
There was 1 error:

1) Test\Files\ObjectStore\ObjectStoreStorageTest::testFOpen with data set #1 (' file.txt')
stream_get_contents() expects parameter 1 to be resource, boolean given

/drone/src/tests/lib/Files/Storage/Storage.php:385

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

@MorrisJobke MorrisJobke merged commit f97048f into stable19 Nov 6, 2020
@MorrisJobke MorrisJobke deleted the backport/23917/stable19 branch November 6, 2020 20:58
@rullzer rullzer mentioned this pull request Nov 9, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 19.0.5

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer @MorrisJobke @ChristophWurst