Use png icons in caldav reminder emails #23915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
added
bug
2. developing
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
added
3. to review
|
This fixes the svg icon issue we discussed the other day. |
ChristophWurst
requested review from
julien-nc,
juliusknorr,
kesselb and
tcitworld
ChristophWurst
approved these changes
Nov 10, 2020
julien-nc
approved these changes
Nov 10, 2020
kesselb
added
4. to release
|
comments integration tests and missing JS assets are both fixed on master in the meantime -> merge |
|
@ChristophWurst @eneiluj Should we backport this? |
|
/backport to stable20 |
|
/backport to stable19 |
|
/backport to stable18 |
This was referenced Nov 11, 2020
|
As of 20.0.8 it looks like the calendar event invite emails are still using svgs instead of pngs (e.g.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CalDAV reminder notification emails still contain svg icons which won't be displayed by some email clients. The icons in most activity notification emails were replaced with pngs (#5483).
All new png icons were converted using inkscape and optimized using
build/image-optimization.sh.See https://css-tricks.com/a-guide-on-svg-support-in-email/ for a list of email clients which do not support svgs.
Feedback is appreciated.