Skip to content

[stable19] Inidicate preview availability in share api responses #23860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2020
Merged

[stable19] Inidicate preview availability in share api responses #23860

merged 1 commit into from
Nov 6, 2020

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Nov 3, 2020 •
edited by MorrisJobke
Loading

⚠️ This backport had conflicts and is incomplete ⚠️ JS compile should fix this - some PHP unit test changes are not in here - most likely because those tests are 20+ only

backport of #23350

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 19.0.5 milestone Nov 3, 2020
@MorrisJobke
Copy link
Member

/compile amend /

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Nov 3, 2020
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 3, 2020
@MorrisJobke
Copy link
Member

/compile amend /

@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the backport/23350/stable19 branch from 125984d to 2718466 Compare November 3, 2020 21:18
@MorrisJobke
Copy link
Member

CI says no :(

@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Nov 4, 2020
@st3iny
Copy link
Member

st3iny commented Nov 4, 2020

php-cs lint fails with:

In ToolInfo.php line 50:
                         
  Undefined index: name

I didn't touch that file :(

@MorrisJobke
Copy link
Member

php-cs lint fails with:

Sometimes it's behaving like that, but we are unsure, what is triggering this yet. Just ignore it for now as it is a cherry-picked backport.

@MorrisJobke

This comment has been minimized.

Sign in to view
@st3iny st3iny self-assigned this Nov 4, 2020
@st3iny st3iny force-pushed the backport/23350/stable19 branch from 2718466 to d45ef86 Compare November 5, 2020 21:42
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Nov 5, 2020
@st3iny
Indicate preview availability in share api responses
af5a94d 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny force-pushed the backport/23350/stable19 branch from d45ef86 to af5a94d Compare November 5, 2020 23:11
@rullzer rullzer merged commit ae99412 into stable19 Nov 6, 2020
@rullzer rullzer deleted the backport/23350/stable19 branch November 6, 2020 07:39
@rullzer rullzer mentioned this pull request Nov 9, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@st3iny st3iny Awaiting requested review from st3iny

Assignees

@st3iny st3iny

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 19.0.5

Development

Successfully merging this pull request may close these issues.

6 participants

@MorrisJobke @st3iny @juliusknorr @skjnldsv @rullzer