Skip to content

No need to check if there is an avatar available, because it is gener… #23839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2020
Merged

No need to check if there is an avatar available, because it is gener… #23839

merged 1 commit into from
Nov 2, 2020

Conversation

@MorrisJobke
Copy link
Member

…ated on the fly nowadays

@MorrisJobke
No need to check if there is an avatar available, because it is gener…
7debc6e 
…ated on the fly nowadays

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added bug 3. to review Waiting for reviews labels Nov 2, 2020
@MorrisJobke MorrisJobke added this to the Nextcloud 21 milestone Nov 2, 2020
@MorrisJobke
Copy link
Member Author

/backport to stable20

@MorrisJobke
Copy link
Member Author

/backport to stable19

@MorrisJobke
Copy link
Member Author

/backport to stable18

@MorrisJobke MorrisJobke requested a review from kesselb November 2, 2020 14:59
@rullzer rullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 2, 2020
@faily-bot
Copy link

faily-bot bot commented Nov 2, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34904: failure

mariadb10.1-php7.3

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\SystemTag\SystemTagManagerTest::testUpdateTagDuplicate with data set #2 (array('one', false, false), array('one', true, true))
Failed asserting that exception of type "OCP\SystemTag\TagNotFoundException" matches expected exception "OCP\SystemTag\TagAlreadyExistsException". Message was: "Tag does not exist" at
/drone/src/lib/private/SystemTag/SystemTagManager.php:238
/drone/src/tests/lib/SystemTag/SystemTagManagerTest.php:382
.

kesselb
kesselb approved these changes Nov 2, 2020
View reviewed changes
Copy link
Collaborator

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MorrisJobke MorrisJobke merged commit 2d67cb9 into master Nov 2, 2020
@MorrisJobke MorrisJobke deleted the fix/noid/avatar-status branch November 2, 2020 18:07
This was referenced Nov 2, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@kesselb kesselb kesselb approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

6 participants

@MorrisJobke @rullzer @ChristophWurst @kesselb @skjnldsv