[stable19] add mount point to quota warning message

[backportbot-nextcloud]

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #22913

[MorrisJobke]

When fixing the conflicts please also add #23193

[R0Wi]

@MorrisJobke @rullzer @skjnldsv since #22913 was merged i get the following error on my NC20 dev instance:

{
   "reqId":"kjRkrtvjauz1r74ZhJkY",
   "level":3,
   "time":"2020-10-10T14:22:24+00:00",
   "remoteAddr":"::1",
   "user":"robin",
   "app":"PHP",
   "method":"GET",
   "url":"/nextcloud/index.php/apps/files/ajax/getstoragestats.php?dir=%2F",
   "message":{
      "Exception":"Error",
      "Message":"Undefined offset: 3 at /var/www/html/nextcloud/lib/private/legacy/OC_Helper.php#548",
      "Code":0,
      "Trace":[
         {
            "file":"/var/www/html/nextcloud/lib/private/legacy/OC_Helper.php",
            "line":548,
            "function":"onError",
            "class":"OC\\Log\\ErrorHandler",
            "type":"::"
         },
         {
            "file":"/var/www/html/nextcloud/apps/files/lib/Helper.php",
            "line":51,
            "function":"getStorageInfo",
            "class":"OC_Helper",
            "type":"::"
         },
         {
            "file":"/var/www/html/nextcloud/apps/files/lib/Controller/AjaxController.php",
            "line":47,
            "function":"buildFileStorageStatistics",
            "class":"OCA\\Files\\Helper",
            "type":"::"
         },
         {
            "file":"/var/www/html/nextcloud/lib/private/AppFramework/Http/Dispatcher.php",
            "line":169,
            "function":"getStorageStats",
            "class":"OCA\\Files\\Controller\\AjaxController",
            "type":"->"
         },
         {
            "file":"/var/www/html/nextcloud/lib/private/AppFramework/Http/Dispatcher.php",
            "line":100,
            "function":"executeController",
            "class":"OC\\AppFramework\\Http\\Dispatcher",
            "type":"->"
         },
         {
            "file":"/var/www/html/nextcloud/lib/private/AppFramework/App.php",
            "line":152,
            "function":"dispatch",
            "class":"OC\\AppFramework\\Http\\Dispatcher",
            "type":"->"
         },
         {
            "file":"/var/www/html/nextcloud/lib/private/Route/Router.php",
            "line":308,
            "function":"main",
            "class":"OC\\AppFramework\\App",
            "type":"::"
         },
         {
            "file":"/var/www/html/nextcloud/lib/base.php",
            "line":1009,
            "function":"match",
            "class":"OC\\Route\\Router",
            "type":"->"
         },
         {
            "file":"/var/www/html/nextcloud/index.php",
            "line":37,
            "function":"handleRequest",
            "class":"OC",
            "type":"::"
         }
      ],
      "File":"/var/www/html/nextcloud/lib/private/Log/ErrorHandler.php",
      "Line":91,
      "CustomMessage":"--"
   },
   "userAgent":"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.121 Safari/537.36",
   "version":"20.0.0.9"
}

Debugged it and it seems like $mount->getMountPoint() sometimes returns values with just two slashes (in my case it returned /robin/ which created the mentioned error).

So maybe this should be fixed first before backporting to NC19. Should i create a separate issue or is this on your radar now? :-)

[icewind1991]

rebased and included #23193 and #23606

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 35436: failure

mysql8.0-php7.2

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Share20\DefaultShareProviderTest::testGetSharedWithGroupWithNode with data set #1 ('smb::whatever', 'files/test.txt', 'files/test2.txt')
Failed asserting that actual size 0 matches expected size 1.

/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:1211

[MorrisJobke]

/backport to stable18

[backportbot-nextcloud]

The backport to stable18 failed. Please do this backport manually.

[MorrisJobke]

#24078