Skip to content

Conversation

@icewind1991
Copy link
Member

  • Don't check for updates for shared storages, let the source storage deal with that
  • Optimize instanceOfStorage('\OCP\Files\IHomeStorage')
  • Optimize initializing source storage

update checking is already handled by the share source

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Sep 15, 2020
@icewind1991 icewind1991 added this to the Nextcloud 20 milestone Sep 15, 2020
@MorrisJobke
Copy link
Member

Mind to fix the unit tests and the code style complaints?

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the shared-storage-init-less branch from 210726a to cfde744 Compare September 16, 2020 11:49
@nextcloud nextcloud deleted a comment from faily-bot bot Sep 16, 2020
@icewind1991
Copy link
Member Author

done

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tested and works 👍

@MorrisJobke MorrisJobke mentioned this pull request Sep 16, 2020
5 tasks
@rullzer rullzer merged commit b0c04a3 into master Sep 17, 2020
@rullzer rullzer deleted the shared-storage-init-less branch September 17, 2020 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants