Skip to content

[stable18] fix possible leaking scope in Flow #22411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2020
Merged

[stable18] fix possible leaking scope in Flow #22411

merged 2 commits into from
Aug 26, 2020

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Aug 25, 2020 •
edited by blizzz
Loading

⚠️ This backport had conflicts and is incomplete ⚠️ this is fine

backport of #22359

@blizzz @backportbot
fix possible leaking scope in Flow
ace667b 
- a configured flow can be brought into consideration, despite its event
  was not fired
- it could either run through
- or run into a RuntimeException and killing processing of valid flows

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 18.0.8 milestone Aug 25, 2020
@faily-bot
Copy link

faily-bot bot commented Aug 25, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32283: failure

mysqlmb4-php7.2

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\Files_Versions\Tests\VersioningTest::testRestoreMovedShare
File content has not changed
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'version 2'
+'version 1'

/drone/src/apps/files_versions/tests/VersioningTest.php:730

db-codecov

Show full log 
There were 30 errors:

1) OCA\Files_Sharing\Tests\ApiTest::testCreateShareUserFile
Error: Call to a member function getMountPoint() on null

/drone/src/lib/private/Share20/Manager.php:305
/drone/src/lib/private/Share20/Manager.php:707
/drone/src/apps/files_sharing/lib/Controller/ShareAPIController.php:581
/drone/src/apps/files_sharing/tests/ApiTest.php:136

2) OCA\Files_Sharing\Tests\ApiTest::testCreateShareUserFolder
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

3) OCA\Files_Sharing\Tests\ApiTest::testCreateShareGroupFile
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

4) OCA\Files_Sharing\Tests\ApiTest::testCreateShareGroupFolder
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

5) OCA\Files_Sharing\Tests\ApiTest::testCreateShareLink
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

6) OCA\Files_Sharing\Tests\ApiTest::testCreateShareLinkPublicUpload
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

7) OCA\Files_Sharing\Tests\ApiTest::testEnforceLinkPassword
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

8) OCA\Files_Sharing\Tests\ApiTest::testSharePermissions
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

9) OCA\Files_Sharing\Tests\ApiTest::testGetAllShares
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

10) OCA\Files_Sharing\Tests\ApiTest::testGetAllSharesWithMe
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

11) OCA\Files_Sharing\Tests\ApiTest::testPublicLinkUrl
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

12) OCA\Files_Sharing\Tests\ApiTest::testGetShareFromFolder
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

13) OCA\Files_Sharing\Tests\ApiTest::testGetShareFromFolderWithFile
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

14) OCA\Files_Sharing\Tests\ApiTest::testGetShareFromFolderReshares
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

15) OCA\Files_Sharing\Tests\ApiTest::testGetShareFromSubFolderReShares
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

16) OCA\Files_Sharing\Tests\ApiTest::testGetShareMultipleSharedFolder
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

17) OCA\Files_Sharing\Tests\ApiTest::testGetShareFromFileReReShares
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

18) OCA\Files_Sharing\Tests\ApiTest::testGetShareFromUnknownId
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

19) OCA\Files_Sharing\Tests\ApiTest::testUpdateShareUpload
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

20) OCA\Files_Sharing\Tests\ApiTest::testUpdateShareExpireDate
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

21) OCA\Files_Sharing\Tests\ApiTest::testDeleteReshare
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

22) OCA\Files_Sharing\Tests\ApiTest::testShareFolderWithAMountPoint
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

23) OCA\Files_Sharing\Tests\ApiTest::testShareStorageMountPoint
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

24) OCA\Files_Sharing\Tests\ApiTest::testPublicLinkExpireDate with data set #0 ('2020-08-30', true)
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

25) OCA\Files_Sharing\Tests\ApiTest::testPublicLinkExpireDate with data set #1 ('abc', false)
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

26) OCA\Files_Sharing\Tests\ApiTest::testPublicLinkExpireDate with data set #2 ('2020-08-30xyz', false)
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

27) OCA\Files_Sharing\Tests\ApiTest::testCreatePublicLinkExpireDateValid
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

28) OCA\Files_Sharing\Tests\ApiTest::testCreatePublicLinkExpireDateInvalidFuture
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

29) OCA\Files_Sharing\Tests\ApiTest::testInvisibleSharesUser
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

30) OCA\Files_Sharing\Tests\ApiTest::testInvisibleSharesGroup
OCP\Lock\LockedException: "share-api-test.txt" is locked

/drone/src/lib/private/Files/View.php:1994
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

Caused by
OCP\Lock\LockedException: "files/0058dfe42c409bf44327e4dcf73500e6" is locked, existing lock on file: 2 shared locks

/drone/src/lib/private/Lock/MemcacheLockingProvider.php:132
/drone/src/lib/private/Files/Storage/Common.php:813
/drone/src/lib/private/Files/View.php:1988
/drone/src/lib/private/Files/View.php:1151
/drone/src/lib/private/Files/View.php:694
/drone/src/apps/files_sharing/tests/ApiTest.php:80

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

@blizzz
adjust since for 18
36260dd 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added the 3. to review Waiting for reviews label Aug 25, 2020
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 25, 2020
@rullzer rullzer merged commit 132b299 into stable18 Aug 26, 2020
@rullzer rullzer deleted the backport/22359/stable18 branch August 26, 2020 18:22
@rullzer rullzer mentioned this pull request Sep 4, 2020
Merged
@MorrisJobke MorrisJobke mentioned this pull request Sep 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@blizzz blizzz blizzz approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@rullzer rullzer Awaiting requested review from rullzer

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: workflows

Projects

None yet

Milestone

Nextcloud 18.0.9

Development

Successfully merging this pull request may close these issues.

5 participants

@ChristophWurst @blizzz @juliusknorr @rullzer