Skip to content

[stable18] Remove encryption option for nextcloud external storage #22343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2020
Merged

[stable18] Remove encryption option for nextcloud external storage #22343

merged 1 commit into from
Aug 21, 2020

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Aug 20, 2020

backport of #22335

@rullzer @backportbot
Remove encryption option for nextcloud external storage
bf37e4a 
Fixes #16017

Since it never worked we should not show it.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 18.0.8 milestone Aug 20, 2020
@rullzer rullzer added the 3. to review Waiting for reviews label Aug 20, 2020
@faily-bot
Copy link

faily-bot bot commented Aug 20, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32121: failure

acceptance-app-files

  • tests/acceptance/features/app-files.feature:108
Show full log 
  Scenario: show shares                                               # /drone/src/tests/acceptance/features/app-files.feature:108
    Given I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt"                            # FilesAppSharingContext::iShareTheLinkFor()
    When I open the "Shares" section                                  # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "Shares"                   # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
      Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

MorrisJobke
MorrisJobke approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

18.0.8 or 18.0.9?

@rullzer rullzer mentioned this pull request Aug 21, 2020
Merged
@rullzer rullzer merged commit e1647c6 into stable18 Aug 21, 2020
@rullzer rullzer deleted the backport/22335/stable18 branch August 21, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@jospoortvliet jospoortvliet Awaiting requested review from jospoortvliet

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 18.0.8

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer @MorrisJobke