Fix some MissingDocblockType or InvalidDocblock warnings.#22253
Merged
MorrisJobke merged 2 commits intomasterfrom Aug 17, 2020
Merged
Fix some MissingDocblockType or InvalidDocblock warnings.#22253MorrisJobke merged 2 commits intomasterfrom
MorrisJobke merged 2 commits intomasterfrom
Conversation
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
commented
Aug 14, 2020
| use OCP\Files\SimpleFS\ISimpleFolder; | ||
| use OCP\ILogger; | ||
| use Sabre\CardDAV\Card; | ||
| use Sabre\VObject\Parameter; |
Contributor
Author
There was a problem hiding this comment.
Import class for
server/apps/dav/lib/CardDAV/PhotoCache.php
Line 266 in b13aa66
Member
|
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 31823: failureacceptance-app-files
Show full log |
Member
|
Please review :) |
ChristophWurst
approved these changes
Aug 17, 2020
MorrisJobke
reviewed
Aug 17, 2020
| <?php | ||
| /** @var $l \OCP\IL10N */ | ||
| /** @var $_ array */ | ||
| /** @var \OCP\IL10N $_ */ |
Member
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix some InvalidDocblock and MissingDocblockType warnings found by psalm.