Deprecate the server container getters #21873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Service locators are an anti pattern. These getters just make it more appealing to do the wrong thing. If you want to locate a service the bad way, just use the `get` method on a container – it will do the same in also one line of code. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
added
3. to review
ChristophWurst
requested review from
MorrisJobke,
icewind1991,
nickvergessen,
rullzer and
skjnldsv
skjnldsv
approved these changes
Jul 16, 2020
|
No version though? |
rullzer
approved these changes
Jul 16, 2020
|
Documented in nextcloud/documentation#2202 and nextcloud/documentation#5160 |
ChristophWurst
added
pending documentation
ChristophWurst
removed
the
pending documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service locators are an anti pattern. These getters just make it more
appealing to do the wrong thing. If you want to locate a service the bad
way, just use the
getmethod on a container – it will do the same inalso one line of code.
Ref #20953