Skip to content

Hello psalm #21787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 18, 2020
Merged

Hello psalm #21787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
7257793
Hello psalm
kesselb Jul 10, 2020
8b3b5ae
Add stubs for phpseclib
kesselb Jul 10, 2020
fd6cdbc
Add template functions
kesselb Jul 10, 2020
6ba55d7
Add psalm as composer dependency
kesselb Jul 10, 2020
dd721fc
Fix: UndefinedFunction Function x does not exist in templates
kesselb Jul 10, 2020
87d738d
Exclude stubs from code style check
kesselb Jul 15, 2020
238f181
Suppress warning for $_ and $l
kesselb Aug 10, 2020
568e1f6
Remove directory/file element.
kesselb Aug 14, 2020
fe3a628
Supress UndefinedGlobalVariable for register_command.php
kesselb Aug 14, 2020
90aa451
Fix variable name for referenced variable.
kesselb Aug 14, 2020
8d18f0a
Suppress warning for template functions.
kesselb Aug 14, 2020
4efca69
Add psalm baseline
MorrisJobke Aug 18, 2020
80056e0
Add a check for fixes in the psalm baseline
MorrisJobke Aug 18, 2020
b70792a
Add stubs for gd, intl, IntlChar, ldap, redis_cluster and xsl
MorrisJobke Aug 18, 2020
c6b251c
Add patches for stubs
MorrisJobke Aug 18, 2020
42bb6cd
Check only the baseline.xml and exclude the psalm.xml from the file c…
MorrisJobke Aug 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/workflows/static-code-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
name: Static code analysis

on: [pull_request]

jobs:
static-code-analysis:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Checkout submodules
shell: bash
run: |
auth_header="$(git config --local --get http.https://github.com/.extraheader)"
git submodule sync --recursive
git -c "http.extraheader=$auth_header" -c protocol.version=2 submodule update --init --force --recursive --depth=1
- name: Remove composer.json
shell: bash
run: rm composer.json composer.lock
- name: Psalm
uses: docker://jakzal/phpqa:php7.4-alpine
with:
args: psalm --monochrome --no-progress --output-format=text --update-baseline
- name: Check for changes in Psalm baseline
run: |
bash -c "[[ ! \"`git status --porcelain build/psalm-baseline.xml`\" ]] || ( echo 'Uncommited changes in Psalm baseline' && git status && git diff && exit 1 )"
1 change: 1 addition & 0 deletions .php_cs.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ $config
->exclude('config')
->exclude('data')
->notPath('3rdparty')
->notPath('build/stubs')
->notPath('composer')
->notPath('vendor')
->in(__DIR__);
Expand Down
1 change: 1 addition & 0 deletions build/files-checker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
'ocs',
'package-lock.json',
'package.json',
'psalm.xml',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need psalm baseline here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No - because it's in the build/ folder which is deleted already. Only new files in the root need to be checked if the release script should either delete them or keep them. I went for the "delete the psalm.xml in the release" way. :)

'public.php',
'README.md',
'remote.php',
Expand Down
Loading