Fix OC_Image new resize functions #20787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Else the wrong mimetype might be set. Resulting in continious regeneration of previews when browsing. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
added
bug
3. to review
rullzer
requested review from
ChristophWurst,
MorrisJobke,
icewind1991 and
juliusknorr
|
Basically without this all previews default to png when resizing. While we need to respect the original (could be jpg). And due to this the caching goes boom as well. |
icewind1991
approved these changes
May 3, 2020
ChristophWurst
added
4. to release
|
@rullzer Backport? |
this bug was introduced by an improvement from @icewind1991 which It hink was not backported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Else the wrong mimetype might be set. Resulting in continious
regeneration of previews when browsing.