Conversation
Signed-off-by: Gary Kim <gary@garykim.dev>
Member
|
Yeah, i'm in favor of excluding templates from phpcs too :) |
rullzer
approved these changes
May 2, 2020
Member
rullzer
left a comment
There was a problem hiding this comment.
Lets do this for now. But yeah maybe the templates are not ideal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix to match php-cs for the CI but I'm thinking it may be better to exclude the templates from php-cs-fixer. This fix doesn't really make much sense. Any thoughts?
EDIT: I changed the fix so the indentation still makes sense but this was the fix made by
cs:fix: