Skip to content

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Apr 22, 2020

Reverts #20554

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please commit the composer.lock too

@rullzer
Copy link
Member Author

rullzer commented Apr 22, 2020

Lets fix that all after the tests pass again ;)

@rullzer rullzer force-pushed the revert-20554-dependabot/composer/build/integration/guzzlehttp/guzzle-6.5.3 branch from 71f22ea to 3fc66a6 Compare April 22, 2020 14:41
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the integration-remote-api tests 👍 Other test failures are unrelated.

The issue seemed to be a mismatch between the Guzzle version in /build/integration and the one in /3rdparty. I do not know if there is an automatic way to keep both in sync.

@rullzer
Copy link
Member Author

rullzer commented Apr 22, 2020

Fixes the integration-remote-api tests +1 Other test failures are unrelated.

The issue seemed to be a mismatch between the Guzzle version in /build/integration and the one in /3rdparty. I do not know if there is an automatic way to keep both in sync.

Yeah shitty php stuff

@rullzer rullzer merged commit 049e9ed into master Apr 22, 2020
@rullzer rullzer deleted the revert-20554-dependabot/composer/build/integration/guzzlehttp/guzzle-6.5.3 branch April 22, 2020 17:53
@rullzer rullzer mentioned this pull request Apr 22, 2020
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants