Allow specifying a default expiration date #20587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
requested review from
ChristophWurst,
georgehrke,
juliusknorr,
nickvergessen and
schiessle
rullzer
force-pushed
the
enh/allow_default_expiration_date
branch
from
2bab841 to
0fb2d10
Compare
rullzer
force-pushed
the
enh/allow_default_expiration_date
branch
from
0fb2d10 to
809914b
Compare
rullzer
added
2. developing
This overrides the max expiration date. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
enh/allow_default_expiration_date
branch
from
809914b to
f4b8623
Compare
rullzer
added
3. to review
|
READY FOR REVIEW |
ChristophWurst
approved these changes
Apr 24, 2020
georgehrke
approved these changes
Apr 24, 2020
georgehrke
added
4. to release
|
/backport to stable18 |
|
backport to stable18 in #20635 with conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This overrides the max expiration date.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl