Fix focus for user actionmenu

[GretaD]

fixes #19464

[jancborchardt]

@caturria is it possible for you to test this as it fixes the issue you reported at #19464 ? Thank you!

[caturria]

Hi, @@GretaD I will spin up a test instance using your branch this afternoon and let you know by tomorrow. Thank you very much for taking care of this.

…

On Apr 9, 2020, at 4:16 AM, Greta ***@***.***> wrote: @GretaD commented on this pull request. In apps/settings/src/components/UserList/UserRowSimple.vue <#20291 (comment)>: > @@ -65,7 +65,11 @@ </ActionButton> </Actions> <div class="userPopoverMenuWrapper"> - <div v-click-outside="hideMenu" class="icon-more" @click="$emit('toggleMenu')" /> + <button + v-click-outside="hideMenu" + class="icon icon-more" Yes, I forgot to remove it. But did you test it, is it ok how it looks now? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20291 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEAWXZDFUHXLEDLWSXK24NLRLV74DANCNFSM4L4DUVHA>.

[caturria]

Hi, Sorry for the delay. Apologies for asking, but if I could get a little guidance on upgrading a backup of my instance to this branch, it would be much appreciated. I have followed all of the steps here: https://docs.nextcloud.com/server/latest/admin_manual/maintenance/manual_upgrade.html (Disabled as many apps as possible, backed up files and database, cloned branch and renamed to original Nextcloud directory, copied config/config.php from old to new, execute php occ upgrade). It fails indicating that the Viewer app’s files have not been correctly replaced. Viewer cannot be disabled, and apps/viewer does not exist in my old Nextcloud instance directory. Kind regards, Jordan.

…

On Apr 9, 2020, at 4:16 AM, Greta ***@***.***> wrote: @GretaD commented on this pull request. In apps/settings/src/components/UserList/UserRowSimple.vue <#20291 (comment)>: > @@ -65,7 +65,11 @@ </ActionButton> </Actions> <div class="userPopoverMenuWrapper"> - <div v-click-outside="hideMenu" class="icon-more" @click="$emit('toggleMenu')" /> + <button + v-click-outside="hideMenu" + class="icon icon-more" Yes, I forgot to remove it. But did you test it, is it ok how it looks now? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20291 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEAWXZDFUHXLEDLWSXK24NLRLV74DANCNFSM4L4DUVHA>.

[GretaD]

(Disabled as many apps as possible, backed up files and database, cloned branch and renamed to original Nextcloud directory, copied config/config.php from old to new, execute php occ upgrade). It fails indicating that the Viewer app’s files have not been correctly replaced. Viewer cannot be disabled, and apps/viewer does not exist in my old Nextcloud instance directory.

Hey Jordan, does the viewer app exist in your apps? If yes, maybe try to delete the app and clone it again: https://github.com/nextcloud/viewer.
It is ok to ask more questions if something else pops up. So dont worry :)

[caturria]

Hi, Alright; I got the update installed. What’s working better: The users list itself reads well now. Scrolling through the options using Control Option Right, here’s what I hear: User Name Display Name Email Groups Quota <Name of first user> <Display name of first user> <Email of first user> 0B, 181.2GB used 90% progress indicator Edit user button. Where problems remain: 1. The administration manual indicates that a mouse hover over a user would reveal an actions menu which offers choices such as to delete or disable a user. There still does not appear to be a way to access this using the keyboard/ screen reader. 2. The ‘Edit User’ button sometimes does not have its name spoken (sometimes it simply reads as ‘Button’). If it reads as ‘Button’, moving the screen reader cursor away from it and then back will cause it to read as ‘Edit user button’ the second time. Does the caption ‘Edit User’ appear dynamically in response to a mouse over event or something to that effect? If so it would need Aria attributes set in order to consistently speak its purpose. 3. The user editing screen is problematic in the following ways: *Still has focus issues, on Mac Voiceover still experiences the broken record effect where it gets stuck in a loop between a few options instead of tracking the form elements from beginning to end; *Does not focus the correct options when edit user is pressed. If I press ’Add a new User’, it correctly focuses the user name field and the form is for the most part accessible, however I cannot set custom quotas (the ’Select user quota’ field does not consistently grab input focus, and if I do get it to accept input and type 50GB for instance, the text disappears as soon as it loses focus. So I only have Default quota, Unlimited, 1GB, 5GB and 10GB to choose from, with no way of knowing which of those has actually been chosen. In summary: *I can read the users list correctly, *I cannot delete or disable a user, *I cannot edit a user without significant difficulty, *I can create a new user, but cannot assign their quotas. Thank you very much for your attention to this matter and for your work towards resolving it. Please stay safe and healthy. Kind regards, Jordan.

…

On Apr 15, 2020, at 4:59 AM, Greta ***@***.***> wrote: (Disabled as many apps as possible, backed up files and database, cloned branch and renamed to original Nextcloud directory, copied config/config.php from old to new, execute php occ upgrade). It fails indicating that the Viewer app’s files have not been correctly replaced. Viewer cannot be disabled, and apps/viewer does not exist in my old Nextcloud instance directory. Hey Jordan, does the viewer app exist in your apps? If yes, maybe try to delete the app and clone it again: https://github.com/nextcloud/viewer <https://github.com/nextcloud/viewer>. It is ok to ask more questions if something else pops up. So dont worry :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20291 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEAWXZACSR4IOE6G2W72XV3RMVZN5ANCNFSM4L4DUVHA>.

[GretaD]

Thank you @caturria for the detailed explanation, thats very helpful. So i will move on and fix the action menu part, and we open another ticket for quota, ok?

[caturria]

Hi, Are you asking me to open another issue for the quota, or saying you’ve done it at your end? Kind regards, Jordan.

…

On Apr 20, 2020, at 6:36 AM, Greta ***@***.***> wrote: Thank you @caturria <https://github.com/caturria> for the detailed explanation, thats very helpful. So i will move on and fix the action menu part, and we open another ticket for quota, ok? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20291 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEAWXZCWUF3GQ7KN6YALDLLRNQQTDANCNFSM4L4DUVHA>.

[GretaD]

Hi, Are you asking me to open another issue for the quota, or saying you’ve done it at your end? Kind regards, Jordan.

Yes please, you open it, i wanted to open it coping what you have wrote on the comment above, but didnt have the time, plus its better if you open it since you have all the details :)

[ChristophWurst]

its merged, please check it out

You have to update this branch :)

[GretaD]

/compile amend /

[GretaD]

i need to fix the border and background color before final review. Icon more has inherited the button characteristics

[GretaD]

This is a bit tricky, somehow the button is focused but I cannot change the hover opacity of the icon-more. It looks like was a z-index problem because when focus via tab, the color is pale, but didnt work.
I added button:focus temporarily to test the tab focus, but have no idea how to add the opacity for icon button.

[ChristophWurst]

/compile amend /

[ChristophWurst]

ah this needs squashing and a rebase

[rullzer]

/compile amend /

[jancborchardt]

Tested and works!