Skip to content

Add Write support to OCP/ICalendar #20178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add Write support to OCP/ICalendar #20178

wants to merge 1 commit into from

Conversation

tcitworld
Copy link
Member

Fixes #20154

@tcitworld tcitworld added this to the Nextcloud 19 milestone Mar 26, 2020
@tcitworld tcitworld force-pushed the ocp-calendar-write-support branch from 0a63edb to 2ea1c8f Compare March 27, 2020 19:01
tcitworld
tcitworld commented Mar 27, 2020
View reviewed changes
tcitworld
tcitworld commented Mar 27, 2020
View reviewed changes
tcitworld
tcitworld commented Mar 27, 2020
View reviewed changes
@tcitworld tcitworld force-pushed the ocp-calendar-write-support branch from 2ea1c8f to ff2b6b5 Compare March 28, 2020 14:32
@georgehrke georgehrke modified the milestones: Nextcloud 19, Nextcloud 20 Apr 3, 2020
@georgehrke
Copy link
Member

Moved to Nc 20 milestone, since we are past feature freeze

@tcitworld
Add Write support to OCP/ICalendar
d00432d 
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld force-pushed the ocp-calendar-write-support branch from ff2b6b5 to d00432d Compare April 13, 2020 14:25
@tcitworld tcitworld marked this pull request as ready for review April 13, 2020 14:27
@tcitworld tcitworld added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 13, 2020
@SergeyMosin SergeyMosin mentioned this pull request May 13, 2020
Open
@MorrisJobke MorrisJobke mentioned this pull request Aug 11, 2020
Merged
57 tasks
@MorrisJobke
Copy link
Member

Moved to Nc 20 milestone, since we are past feature freeze

Unfortunately we are close to miss this again. I feel also a bit uncomfortable with adding a that big change that late.

@rotdrop
Copy link
Contributor

rotdrop commented Oct 6, 2020 •
edited
Loading

FYI, I have rebased the branch of @tcitworld to the current master branch and submitted the merge request #23234 (mostly in order to get the merge checks run). Would be great to have this integrated.

Other things I still miss are

  • refresh the list of calendars after addings or removing or sharing calenders by whatever means
  • create/delete calendars
  • share/unshare calendars

But even without those 3 points the pull request would reduce the need to access internals of the dav-app.

This was referenced Oct 6, 2020
Open
Closed
@skjnldsv skjnldsv closed this Oct 31, 2020
@MorrisJobke MorrisJobke deleted the ocp-calendar-write-support branch November 3, 2020 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgehrke georgehrke georgehrke left review comments

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: dav
Projects
None yet
Milestone
Nextcloud 21
Development

Successfully merging this pull request may close these issues.

PHP Calendar API: Write support
5 participants
@tcitworld @georgehrke @MorrisJobke @rotdrop @skjnldsv