Skip to content

fixes auto-detecting UUID attributes#20039

Merged
blizzz merged 1 commit intomasterfrom
fix/19549/fix-uuid-attr-detection
Mar 20, 2020
Merged

fixes auto-detecting UUID attributes#20039
blizzz merged 1 commit intomasterfrom
fix/19549/fix-uuid-attr-detection

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Mar 19, 2020

fixes #19970 (a regression introduced with #19549)

  • the continue (and later the early return) avoided proper looping over the other attribute candidates
  • less code is better

@blizzz
fixes auto-detecting UUID attributes
77c63e3 
the continue (and later the early return) avoided proper looping over the
attribute candidates.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added this to the Nextcloud 19 milestone Mar 19, 2020
@blizzz blizzz mentioned this pull request Mar 19, 2020
Closed
@blizzz
Copy link
Member Author

blizzz commented Mar 19, 2020

/backport to stable18

@blizzz
Copy link
Member Author

blizzz commented Mar 19, 2020

/backport to stable17

@blizzz
Copy link
Member Author

blizzz commented Mar 19, 2020

/backport to stable16

@blizzz blizzz merged commit 5817047 into master Mar 20, 2020
@blizzz blizzz deleted the fix/19549/fix-uuid-attr-detection branch March 20, 2020 10:06
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 20, 2020
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Mar 20, 2020

backport to stable18 in #20046

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 20, 2020
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Mar 20, 2020

backport to stable17 in #20047

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 20, 2020
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Mar 20, 2020

backport to stable16 in #20048

@kesselb kesselb mentioned this pull request Mar 26, 2020
Closed
@vpluar
Copy link

vpluar commented May 7, 2020

maybe it is still happening in 18.04? I have just made a fresh install of nextcloud 18.04 I connect to my microsoft AD 2019. I see users and groups in the ldap integration section... I just select what groups I want but in the user section just see users... not groups.

@blizzz
Copy link
Member Author

blizzz commented May 7, 2020

maybe it is still happening in 18.04? I have just made a fresh install of nextcloud 18.04 I connect to my microsoft AD 2019. I see users and groups in the ldap integration section... I just select what groups I want but in the user section just see users... not groups.

Most likely a config issue then, so I would like to ask you to raise your question in the forums: https://help.nextcloud.com

If you wish support with setup issues from Nextcloud GmbH we offer this as part of the Nextcloud subscription. Learn more about this at https://nextcloud.com/enterprise/

@vpluar
Copy link

vpluar commented May 7, 2020

ok, I will do it. Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: ldap regression

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

NC 18.02: ldap groups no more visible

4 participants

@blizzz @vpluar @juliusknorr @skjnldsv