Fix single "ScopeContext" passed to "setScopes"#19989
Merged
Conversation
"setScopes" expects an array, but a single "ScopeContext" was being passed instead. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Member
Author
|
/backport to stable18 |
rullzer
approved these changes
Mar 16, 2020
Contributor
|
Nice finding 👍 I was really wondering why PHPStorm does not complain about those code. It seems that for some reason |
|
backport to stable18 in #20001 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

setScopesexpects an array, but a singleScopeContextwas being passed instead.How to test
Result with this pull request
The folder appears in the list.
Result without this pull request
The error Could not create folder is shown (although if the public share page is reloaded it can be seen that the folder was actually created).