Don't break when one remote share is down

[nickvergessen]

getFileInfo can also return false
Found while trying to improve on #14797

[kesselb]

server/apps/files_sharing/js/sharedfilelist.js

Lines 308 to 318 in 445274c

	var file = {
	shareOwner: share.owner + '@' + share.remote.replace(/.*?:\/\//g, ''),
	name: OC.basename(share.mountpoint),
	mtime: share.mtime * 1000,
	mimetype: share.mimetype,
	type: share.type,
	id: share.file_id,
	path: OC.dirname(share.mountpoint),
	permissions: share.permissions,
	tags: share.tags || []
	}

Please consider to update the code here. Right now all those fields are expected.

[nickvergessen]

Sure we can add something like:

			$share['mimetype'] = 'httpd/unix-directory';
			$share['mtime'] = 0;
			$share['permissions'] = Constants::PERMISSION_READ | Constants::PERMISSION_DELETE;
			$share['type'] = 'dir';
			$share['file_id'] = 0;

But the main issue stays. The info is wrong and deleting doesnt work either. Also I don't see a problem in my console/UI without that (apart from no mimetype icon being displayed).

I think someone needs to have a proper look and handle unavailable shares in a much better fashion globally. For now getting rid of the broken part of the response is good enough for me.

[rullzer]

looks sane

[nickvergessen]

/backport to stable18

[backportbot-nextcloud]

backport to stable18 in #19886