Properly emit Viewer event on files and files_sharing

[skjnldsv]

Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com

[skjnldsv]

/backport to stable18

[ChristophWurst]

Looks good :)

[danxuliu]

Replacing Symfony\Component\EventDispatcher\GenericEvent with OCP\EventDispatcher\GenericEvent breaks the apps that listen to the OCA\Files_Sharing::loadAdditionalScripts and OCA\Files_Sharing::loadAdditionalScripts::publicShareAuth events, so this API change should be documented somewhere (although there are probably not a lot of apps using those events, but still ;-) ).

[skjnldsv]

It does?
I don't understand why ? :)

[danxuliu]

It does if types are used in the event handler, as OCP\EventDispatcher\GenericEvent does not extend Symfony\Component\EventDispatcher\GenericEvent and thus can not replace it.

I have now seen that this pull request is meant to be backported to stable18. Please keep in mind that the event type change could go in for Nextcloud 19, but it should not be merged in stable18.

[skjnldsv]

So reverting is the safest way?
Or should I just not backport the GenericEvent change?
What do you recommend here? :)

[skjnldsv]

So I can migrate to IEventDispatcher, but I should keep Symfony\Component\EventDispatcher\GenericEvent, right?

[danxuliu]

Unfortunately you can not use IEventDispatcher either, because IEventDispatcher dispatches an OCP\EventDispatcher\Event, so it can not dispatch a Symfony\Component\EventDispatcher\GenericEvent. And as IEventDispatcher can not be used dispatchTyped can not be used either.

Similarly, dispatchTyped can not be used either in apps/files_sharing/list.php, because getEventDispatcher() returns a Symfony\Component\EventDispatcher\EventDispatcherInterface.

As EventDispatcherInterface is no longer replaced by IEventDispatcher the unit test fixes do not apply, so the commit was removed.

And finally, personally I would also drop the commit to use dispatchTyped, as it is used only once and while convenient it makes that call inconsistent with the rest of the LoadViewer dispatchers as well as with the other dispatchs in ViewCVontroller. But that is nitpicking, of course ;-) In any case, dispatchTyped was introduced in Nextcloud 18, so even if the commit is not dropped it should be safe to backport it to stable18.

[skjnldsv]

@danxuliu integration-remote-api fails

PHP Fatal error: Declaration of OC\EventDispatcher\SymfonyAdapter::dispatch($eventName, $event = NULL) must be compatible with Symfony\Contracts\EventDispatcher\EventDispatcherInterface::dispatch(object $event, ?string $eventName = NULL): object in /drone/src/lib/private/EventDispatcher/SymfonyAdapter.php on line 37
145

[danxuliu]

PHP Fatal error: Declaration of OC\EventDispatcher\SymfonyAdapter::dispatch($eventName, $event = NULL) must be compatible with Symfony\Contracts\EventDispatcher\EventDispatcherInterface::dispatch(object $event, ?string $eventName = NULL): object in /drone/src/lib/private/EventDispatcher/SymfonyAdapter.php on line 37
145

Although it looks highly suspicious ;-) this is not caused by this pull request (it happens on master too), but by the Behat version bump in integration tests (which causes Symfony 5 instead of Symfony 4 to be installed by composer). I will send a fix for that (in another pull request, of course ;-) ).

[backportbot-nextcloud]

backport to stable18 in #19897