Fix hostname in Apple configuration profile#19704
Merged
rullzer merged 2 commits intonextcloud:masterfrom Mar 9, 2020
Nils160988:master
Merged
Fix hostname in Apple configuration profile#19704rullzer merged 2 commits intonextcloud:masterfrom Nils160988:master
rullzer merged 2 commits intonextcloud:masterfrom
Nils160988:master
Conversation
Signed-off-by: Nils Wittenbrink <nilswittenbrink@web.de>
Contributor
One test fails due the other method used to get the url. Above patch should mock getBaseUrl properly. |
Contributor
Author
|
Fixed the test as @kesselb suggested |
georgehrke
approved these changes
Mar 4, 2020
Member
|
@Nils160988 Thx for the contribution! |
rullzer
approved these changes
Mar 9, 2020
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Contributor
Author
|
Thanks for merging :) |
Member
|
/backport to stable18 |
Member
|
/backport to stable17 |
|
backport to stable18 in #19884 |
|
backport to stable17 in #19885 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19656
Signed-off-by: Nils Wittenbrink nilswittenbrink@web.de