Update check for outdated php version. #19580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should rather update it. Right now that would mean php7.2 there since that is no longer developed etc. |
kesselb
force-pushed
the
debt/noid/outdated-check
branch
from
328ae42 to
8846b94
Compare
kesselb
changed the title
kesselb
force-pushed
the
debt/noid/outdated-check
branch
from
8846b94 to
6ea6132
Compare
Fine by me. |
ChristophWurst
approved these changes
Feb 24, 2020
rullzer
approved these changes
Feb 24, 2020
|
CI says no... |
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
debt/noid/outdated-check
branch
from
6ea6132 to
f228d73
Compare
|
Is there a technical reason for this? Because the version check was not raised: https://github.com/nextcloud/server/blob/master/lib/versioncheck.php#L28 We just noticed it in #22507. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show warning for PHP 7.2