Remove deprecated global variables #19357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
approved these changes
Feb 7, 2020
juliusknorr
requested changes
Feb 7, 2020
There was a problem hiding this comment.
We should at least fix our internal usages in server before removing them. This breaks the files app out of the box 😉
Uncaught (in promise) ReferenceError: humanFileSize is not defined
at FileList._createRow (filelist.js:1609)
at FileList.fileList._createRow (tagsplugin.js:236)
at FileList.e._createRow (comments.js:1)
at FileList.e._createRow (additionalScripts.js:1)
at FileList._renderRow (filelist.js:1793)
at FileList._nextPage (filelist.js:1281)
at FileList.setFiles (filelist.js:1359)
at FileList.reloadCallback (filelist.js:2098)
at Object.<anonymous> (main.js:25)
at c (main.js:25)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
skjnldsv
reviewed
Feb 7, 2020
skjnldsv
reviewed
Feb 7, 2020
skjnldsv
reviewed
Feb 7, 2020
ChristophWurst
force-pushed
the
techdebt/remove-deprecated-globals
branch
from
65573f4 to
a685c3c
Compare
|
This removes ~100KB from each bundle, btw |
ChristophWurst
added
the
pending documentation
ChristophWurst
force-pushed
the
techdebt/remove-deprecated-globals
branch
from
a685c3c to
07a1b5f
Compare
|
Needs a rebase. |
ChristophWurst
force-pushed
the
techdebt/remove-deprecated-globals
branch
from
07a1b5f to
55cb6b0
Compare
|
There seems to be a JSUnit failure, is that unrelated? |
|
Whoopsie. A few tests are indeed failing. |
ChristophWurst
added
2. developing
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
techdebt/remove-deprecated-globals
branch
from
55cb6b0 to
bb1d8b3
Compare
|
But the rest should be fine. |
ChristophWurst
added a commit
to nextcloud/documentation
that referenced
this pull request
Apr 10, 2020
Ref nextcloud/server#19357 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
removed
the
pending documentation
MorrisJobke
added a commit
to nextcloud/files_videoplayer
that referenced
this pull request
Sep 15, 2020
nextcloud/server#19357 Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few apps might break because nobody cares to adapt. So let's remove this sooner than later :)