enable option '--no-interaction' for db:convert-type

[BernieO]

Signed-off-by: Bernhard Ostertag bernieo.code@gmx.de

When converting database type the option --no-interaction is currently ignored, which makes it impossible for some users to change the database type via occ (for example see: https://help.nextcloud.com/t/failed-to-connect-to-database-when-converting-sqlite-to-mysql/66782/7)

This pull request adds a check for the option --no-interaction for the command occ db:convert-type

[kesselb]

Thanks 👍

Console has some logic in place for such cases: https://github.com/nextcloud/3rdparty/blob/cc36ef4e9f63e0dd6009851d6f8a84a31911b57b/symfony/console/Helper/QuestionHelper.php#L49-L73

Index: core/Command/Db/ConvertType.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- core/Command/Db/ConvertType.php	(revision b7f93cc56bb1f7d9383165ebf29111fbd2bd6ab1)
+++ core/Command/Db/ConvertType.php	(date 1577458133111)
@@ -212,10 +212,11 @@
 				$output->writeln('<comment>can be included by specifying the --all-apps option.</comment>');
 			}
 
+			$continueConversion = !$input->isInteractive(); // assume yes for --no-interaction and no otherwise.
+			$question = new ConfirmationQuestion('Continue with the conversion (y/n)? [n] ', $continueConversion);
+
 			/** @var QuestionHelper $helper */
 			$helper = $this->getHelper('question');
-			$question = new ConfirmationQuestion('Continue with the conversion (y/n)? [n] ', false);
-
 			if (!$helper->ask($input, $output, $question)) {
 				return;
 			}

I would suggest to introduce a new variable with the default answer. Set it to true for no-interactive and false otherwise.

[BernieO]

That looks better. Should I create another pull request with the changes you proposed?

Another thing: should that as option be added to the documentation here (I could do that as well):
https://github.com/nextcloud/documentation/blob/master/admin_manual/configuration_database/db_conversion.rst
?

[kesselb]

That looks better. Should I create another pull request with the changes you proposed?

Update this pr if possible. We can also keep the current approach. The result is the same.

should that as option be added to the documentation here

Yes. Thanks in advance 👍

[BernieO]

I changed the documentation accordingly: nextcloud/documentation#1755

I suggest to backport this to stable 17 and stable 16.

[kesselb]

If someone of you could press merge ;)

[ChristophWurst]

mörged!