Skip to content

fix overlapping #18473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2020
Merged

fix overlapping #18473

merged 1 commit into from
Jan 6, 2020

Conversation

@GretaD
Copy link
Contributor

@GretaD GretaD commented Dec 18, 2019

fixes #18414

@GretaD
fix overlapping
ab8a8c0 
Signed-off-by: GretaD <gretadoci@gmail.com>
@GretaD GretaD requested a review from kesselb December 18, 2019 14:57
@GretaD GretaD added 3. to review Waiting for reviews design Design, UI, UX, etc. labels Dec 18, 2019
@GretaD GretaD requested a review from skjnldsv December 18, 2019 14:58
@kesselb
Copy link
Collaborator

kesselb commented Dec 19, 2019

LGTM 👍

nextcloud test_apps_files__dir=_ (3)
nextcloud test_apps_files__dir=_ (2)
nextcloud test_apps_files__dir=_ (1)
nextcloud test_apps_files__dir=_

@kesselb
Copy link
Collaborator

kesselb commented Dec 27, 2019

@skjnldsv do you want me to test it again? There is no change since I approved it 😕 Perhaps you forgot to rebase? ;)

gary-kim
gary-kim approved these changes Dec 27, 2019
View reviewed changes
Copy link
Member

@gary-kim gary-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GretaD
Copy link
Contributor Author

GretaD commented Jan 6, 2020

@skjnldsv @kesselb @gary-kim is this ready for release?

skjnldsv
skjnldsv approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@skjnldsv skjnldsv merged commit e5d3efb into master Jan 6, 2020
@skjnldsv skjnldsv deleted the bugfix/18414/fix_header_overlapping branch January 6, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@gary-kim gary-kim gary-kim approved these changes

@kesselb kesselb Awaiting requested review from kesselb

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

No one assigned

Labels

3. to review Waiting for reviews design Design, UI, UX, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

First entry is overlapped by header (again)

5 participants

@GretaD @kesselb @skjnldsv @gary-kim